jongyoul commented on code in PR #4556:
URL: https://github.com/apache/zeppelin/pull/4556#discussion_r1070608092


##########
zeppelin-interpreter-parent/pom.xml:
##########
@@ -113,6 +113,7 @@
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-shade-plugin</artifactId>
           <configuration>
+            <createDependencyReducedPom>false</createDependencyReducedPom>

Review Comment:
   It's a bit complicated but let me explain it.
   
   When we install jar, `maven-instll-plugin` tries to install the file under 
`/target/*.jar` into `.m2` but our shade script store shaded jars under 
`/interpreter/{interpreter.name}` so the file under `/target` directory is an 
original file which is not shaded. so `maven-install-plugin` copies the 
original file into `.m2` directly as a result. BTW, in case of pom file, 
`dependency-reduced-pom` would be copied into `.m2` directory even if the jar 
is not shaded. In our old version of shade plugin, the default setting didn't 
create `dependency-reduced-pom` when using `outputFile` configuration but in 
the latest one, the plugin creates it even if we use `outputFile` setting. So I 
disabled to create it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to