Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-123232193
It's a nice contribution, and I left a few comments in the code.
I like the fact that you used vm in the controller. However the
directive/controller combo can be improved.
* Either by making visible directive general (taking a callback function),
and moving all the scope part back to the controller (vm)
* Either by making a createNewNote directive, and deleting the
``note-name-dialog.html` file and note-``name.controller.js`` files
I'm also getting this:
``XMLHttpRequest cannot load javascript:void(0);. Cross origin requests are
only supported for protocol schemes: http, data, chrome, chrome-extension,
https, chrome-extension-resource.``
when I click on new notebook for the first time after page load, any idea?
(coming from jquery.js)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
