Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/156#issuecomment-124004063
  
    Just left a few more comments.
    I will do a final test, to be sure everything is working once its done.
    
    I'm not sure ``$('#noteName').select();`` is really necessary, mainly 
because dom modification code should not be inside a controller. Using 
``autofocus`` directive might have the same effect. Otherwise, using 
angular.element syntax would be better if you think it is essential.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to