Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/389#issuecomment-157302094
  
    I'm a bit late for the party,
    However I would prefer the ``isReadOnly()`` part in zeppelin-web to be 
handled as a DataFactory instead of storing it in the $rootScope and copy 
pasting the same function in every controllers.
    
    There is a good example here:
    
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/components/notebookListDataFactory/notebookList.datafactory.js
    
    And you can see it in action here:
    
https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-web/src/components/navbar/navbar.controller.js


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to