Github user babokim commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/389#issuecomment-157395618
  
    @corneadoug Thank you for your advise. I tried storing system config values 
in a DataFactory. That way also has similar duplication. To set the data in 
that DataFactory after receiving from the Websocket, each controller should 
have receiver function like the following code. That function code also is 
duplicated in every controllers.
    
    ```
    angular.module('zeppelinWebApp').factory('websocketEvents', function ( ... 
) {
      websocketCalls.ws.onMessage(function(event) {
        ...
        } else if (op === 'GET_SYSTEM_CONF') {
          $rootScope.$broadcast('setSystemConf', data.conf);
        }
      }
    }
    
    angular.module('zeppelinWebApp').controller('NotebookCtrl'..., 
function(...)  {
      $scope.$on('setSystemConf', function(event, systemConf  {
        systemConfigDataFactory.setSystemConf(systemConf);
      });
    ``` 
    
    If there is another way to set system config data, please let me know. 
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to