Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-200917099
@echarles Thanks for taking a look!
> Good idea to reuse the rscala from the spark dist.
Little bit more precisely,
https://github.com/datalayer/zeppelin-datalayer/pull/7 does not reuse rscala
from the spark dist. ZeppelinR.java completely replaces rscala library.
What https://github.com/datalayer/zeppelin-datalayer/pull/7 reuse from
spark dist is SparkR package. To support run r interpreter without
spark-distribution installed on the system.
> I would prefer keeping the SparkRInterpreterTest with it PowerMock (to
mock static) which does not need any R on the host and add indeed as you did an
integration test which needs R on the host.
Sure, please bring SparkRInterpreterTest back if you prefer.
> I see you changed something for the SPARK_HOME which didn't work as
@jeffsteinmetz pointer - will look this we.
I think https://github.com/datalayer/zeppelin-datalayer/pull/7 addresses
all @jeffsteinmetz 's comment. isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
