Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/702#issuecomment-202170557
It is not at all a surprise that you would propose to merge 702---a few
hours after I asked for community involvement on another PR, where you objected.
This is absolutely the opposite of the consensus the community has
repeatedly reached about the R issue.
At the moment, this PR has zero adoption. You made a major change in its
architecture a day ago that no-one has had a chance to try out.
And it has zero tests --- because the CI issue still isn't solved, they've
been replaced by tests that don't cover the PRs functionality and don't even
test if it can connect to R or Spark.
Will you be abiding by the community's consensus or do we really need to
start a seventh discussion about this on the mailing list?
> On Mar 27, 2016, at 7:23 PM, Lee moon soo <notificati...@github.com>
wrote:
>
> @echarles Thanks for taking a look datalayer#7.
> I have tested latest commit and it works well for me. Also i have
verified RInterpreter working with binary package generated by -Pbuild-distr
flag.
>
> Wait for @jeffsteinmetz provides additional review.
>
> Meanwhile, how about taking care of (b) and (c) in separate PR ?
> While basic R interpreter functionality is working and tests are ready, i
think we can merge it and improvements like (b), (c) as well as implementing
getProgress(), and cancel() can be done in separate PR. So more people can get
involved.
>
> What do you think?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
