[
https://issues.apache.org/jira/browse/ZOOKEEPER-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068094#comment-13068094
]
[email protected] commented on ZOOKEEPER-999:
---------------------------------------------------------
bq. On 2011-07-19 22:46:10, Patrick Hunt wrote:
bq. > 1) src/recipes/election has been added recently to trunk, are changes
needed there as well? (see my comments below - seems like if we separated out
pkg building from regular build it would make this more explicit/obvious)
bq. >
bq. > 2) i've been wondering for a while, perhaps we should have different
scripts for zkServer.sh depending upon whether running in "development mode"
and running in "package mode". There's alot of cruft in there having to do with
determining which mode we are in and then setting up appropriately (zkCli,
zkServer, zkCleanup, etc...).
What do you think of this idea (2 in particular?) I guess hadoop is fine with
this mixed use? Perhaps we can take some ideas from there an apply?
bq. On 2011-07-19 22:46:10, Patrick Hunt wrote:
bq. > ./bin/zkEnv.sh, lines 31-35
bq. > <https://reviews.apache.org/r/1143/diff/1/?file=26344#file26344line31>
bq. >
bq. > this was recently changed by ZOOKEEPER-1084 to either use the
variable if passed, or use ../conf (but not ../etc)
bq.
bq. Eric Yang wrote:
bq. Hadoop stack software used the same pattern *_HOME/conf for
configuration directory. This naming convention doesn't work when *_HOME/conf
is collapsed into a single directory, (i.e. /usr) A proposal maded in
HADOOP-6255 to address this issue. For packaged software, $PREFIX/etc/$project
will be the naming convention for configuration directory. For developer, it
will use $PREFIX/conf for source code build. This patch already merged change
for ZOOKEEPER-1084, it will honor $ZOOCFGDIR if it is defined.
we should look at moving to best practices, esp if hadoop already figured this
out. Would you mind starting a ZK wiki page detailing both the bin/* scripts
and how it fits into packaging? Or perhaps we can document it within the
scripts themselves? I'd like to see us start deprecating (and eventually
removing) the old ways of doing things an moving people to whatever our current
best practices are.
bq. On 2011-07-19 22:46:10, Patrick Hunt wrote:
bq. > ./build.xml, line 155
bq. > <https://reviews.apache.org/r/1143/diff/1/?file=26346#file26346line155>
bq. >
bq. > in my case aclocal does not reside in /usr/local... (ubuntu natty)
but rather /usr/share
bq. >
bq. > can we determine this in some other way?
bq.
bq. Eric Yang wrote:
bq. I am fine to use /usr/share as default. It is also possible to
overwrite this in build.properties. Conditional checking to set property is
not pretty in ant, it may be better to leave this as a property for now.
I'm fine either way - as long as it doesn't impact the ability for people to
easily checkout the code and build. I wasn't sure how this would effect that.
bq. On 2011-07-19 22:46:10, Patrick Hunt wrote:
bq. > ./src/packages/update-zookeeper-env.sh, line 131
bq. > <https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131>
bq. >
bq. > the group used is hadoop? (seems fine, just wondering...)
bq.
bq. Eric Yang wrote:
bq. I set the full stack of the software to be ownership by group hadoop
for easier file ownership management.
seems fine. Are you planning to participate in Bigtop? Would love to have you
involved. It would be great to nail all this type of thing down so that it will
be consistent. (or make it easy to configure if there's no consensus, ie figure
out what ppl agree on and what not).
bq. On 2011-07-19 22:46:10, Patrick Hunt wrote:
bq. > ./src/packages/templates/conf/zoo.cfg, lines 1-12
bq. > <https://reviews.apache.org/r/1143/diff/1/?file=26364#file26364line1>
bq. >
bq. > is there a way to not duplicate this? (a sample is also in conf)
bq.
bq. Eric Yang wrote:
bq. How about generate conf/zoo_sample.cfg from
src/packages/templates/conf/zoo.cfg as part of the build process?
My concerns are: 1) make it easy for ppl to get started with development, 2)
try to limit duplication, esp stuff we're likely to forget to update, 3)
generated code should go into build (eventually target once maven is here)
perhaps a conf/zoo_template.cfg that could be used by 1), and generate into
build/.../src/packages/templates/conf/zoo.cfg for use in packaging?
- Patrick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1143/#review1120
-----------------------------------------------------------
On 2011-07-19 22:15:38, Patrick Hunt wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1143/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-19 22:15:38)
bq.
bq.
bq. Review request for zookeeper and Mahadev Konar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This goal of this ticket is to generate a set of RPM/debian package which
integrate well with RPM sets created by HADOOP-6255.
bq.
bq.
bq. This addresses bug ZOOKEEPER-999.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-999
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./bin/zkCleanup.sh 1141173
bq. ./bin/zkCli.sh 1141173
bq. ./bin/zkEnv.sh 1141173
bq. ./bin/zkServer.sh 1141173
bq. ./build.xml 1141176
bq. ./ivy.xml 1141173
bq. ./src/contrib/build-contrib.xml 1141173
bq. ./src/contrib/build.xml 1141173
bq. ./src/contrib/zkpython/build.xml 1141173
bq. ./src/contrib/zkpython/ivy.xml PRE-CREATION
bq. ./src/contrib/zkpython/src/packages/deb/zkpython.control/control
PRE-CREATION
bq. ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION
bq. ./src/contrib/zkpython/src/python/setup.py 1141173
bq. ./src/packages/deb/init.d/zookeeper PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/conffile PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/control PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/postinst PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/postrm PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/preinst PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/prerm PRE-CREATION
bq. ./src/packages/rpm/init.d/zookeeper PRE-CREATION
bq. ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION
bq. ./src/packages/templates/conf/zoo.cfg PRE-CREATION
bq. ./src/packages/update-zookeeper-env.sh PRE-CREATION
bq. ./src/recipes/build-recipes.xml 1141173
bq. ./src/recipes/build.xml 1141173
bq. ./src/recipes/lock/build.xml 1141173
bq. ./src/recipes/queue/build.xml 1141173
bq.
bq. Diff: https://reviews.apache.org/r/1143/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Patrick
bq.
bq.
> Create an package integration project
> -------------------------------------
>
> Key: ZOOKEEPER-999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-999
> Project: ZooKeeper
> Issue Type: New Feature
> Components: build
> Environment: Java 6, RHEL/Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-999-1.patch, ZOOKEEPER-999-2.patch,
> ZOOKEEPER-999-3.patch, ZOOKEEPER-999-4.patch, ZOOKEEPER-999.patch
>
>
> This goal of this ticket is to generate a set of RPM/debian package which
> integrate well with RPM sets created by HADOOP-6255.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
