[
https://issues.apache.org/jira/browse/ZOOKEEPER-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068109#comment-13068109
]
[email protected] commented on ZOOKEEPER-999:
---------------------------------------------------------
bq. On 2011-07-19 22:46:10, Patrick Hunt wrote:
bq. > 1) src/recipes/election has been added recently to trunk, are changes
needed there as well? (see my comments below - seems like if we separated out
pkg building from regular build it would make this more explicit/obvious)
bq. >
bq. > 2) i've been wondering for a while, perhaps we should have different
scripts for zkServer.sh depending upon whether running in "development mode"
and running in "package mode". There's alot of cruft in there having to do with
determining which mode we are in and then setting up appropriately (zkCli,
zkServer, zkCleanup, etc...).
bq.
bq. Patrick Hunt wrote:
bq. What do you think of this idea (2 in particular?) I guess hadoop is
fine with this mixed use? Perhaps we can take some ideas from there an apply?
bq.
bq. Eric Yang wrote:
bq. 1) Is there a plan to grow more recipes? If yes, I would recommend to
use maven for build script because it allows submodule to call parent build
profiles. We can have a centralized template for creating recipes rpm/deb
packages. Ant recursive structure is difficult to maintain because the
subdirectory build.xml file needs to refer to parent build.xml to include
packaging templates, which generates too much repetitive tasks. Let's put
recipes packaging as a separate task for future enhancement.
bq.
bq. 2) Code reuse would be ideal. I am not sure if we want to have
different scripts, perhaps consolidated functions would be sufficient to make
organization cleaner.
RE on 2) reapply some logic from Hadoop would be good. i.e.
$PREFIX/sbin/*-daemon.sh and $PREFIX/libexec/*-config.sh would make the pattern
cleaner.
bq. On 2011-07-19 22:46:10, Patrick Hunt wrote:
bq. > ./src/packages/update-zookeeper-env.sh, line 131
bq. > <https://reviews.apache.org/r/1143/diff/1/?file=26365#file26365line131>
bq. >
bq. > the group used is hadoop? (seems fine, just wondering...)
bq.
bq. Eric Yang wrote:
bq. I set the full stack of the software to be ownership by group hadoop
for easier file ownership management.
bq.
bq. Patrick Hunt wrote:
bq. seems fine. Are you planning to participate in Bigtop? Would love to
have you involved. It would be great to nail all this type of thing down so
that it will be consistent. (or make it easy to configure if there's no
consensus, ie figure out what ppl agree on and what not).
I love to participate in Bigtop. For now, I am making sure the packages are
consistent.
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1143/#review1120
-----------------------------------------------------------
On 2011-07-19 22:15:38, Patrick Hunt wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1143/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-19 22:15:38)
bq.
bq.
bq. Review request for zookeeper and Mahadev Konar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This goal of this ticket is to generate a set of RPM/debian package which
integrate well with RPM sets created by HADOOP-6255.
bq.
bq.
bq. This addresses bug ZOOKEEPER-999.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-999
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ./bin/zkCleanup.sh 1141173
bq. ./bin/zkCli.sh 1141173
bq. ./bin/zkEnv.sh 1141173
bq. ./bin/zkServer.sh 1141173
bq. ./build.xml 1141176
bq. ./ivy.xml 1141173
bq. ./src/contrib/build-contrib.xml 1141173
bq. ./src/contrib/build.xml 1141173
bq. ./src/contrib/zkpython/build.xml 1141173
bq. ./src/contrib/zkpython/ivy.xml PRE-CREATION
bq. ./src/contrib/zkpython/src/packages/deb/zkpython.control/control
PRE-CREATION
bq. ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION
bq. ./src/contrib/zkpython/src/python/setup.py 1141173
bq. ./src/packages/deb/init.d/zookeeper PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/conffile PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/control PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/postinst PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/postrm PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/preinst PRE-CREATION
bq. ./src/packages/deb/zookeeper.control/prerm PRE-CREATION
bq. ./src/packages/rpm/init.d/zookeeper PRE-CREATION
bq. ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION
bq. ./src/packages/templates/conf/zoo.cfg PRE-CREATION
bq. ./src/packages/update-zookeeper-env.sh PRE-CREATION
bq. ./src/recipes/build-recipes.xml 1141173
bq. ./src/recipes/build.xml 1141173
bq. ./src/recipes/lock/build.xml 1141173
bq. ./src/recipes/queue/build.xml 1141173
bq.
bq. Diff: https://reviews.apache.org/r/1143/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Patrick
bq.
bq.
> Create an package integration project
> -------------------------------------
>
> Key: ZOOKEEPER-999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-999
> Project: ZooKeeper
> Issue Type: New Feature
> Components: build
> Environment: Java 6, RHEL/Ubuntu
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-999-1.patch, ZOOKEEPER-999-2.patch,
> ZOOKEEPER-999-3.patch, ZOOKEEPER-999-4.patch, ZOOKEEPER-999.patch
>
>
> This goal of this ticket is to generate a set of RPM/debian package which
> integrate well with RPM sets created by HADOOP-6255.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
