[
https://issues.apache.org/jira/browse/ZOOKEEPER-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096214#comment-13096214
]
[email protected] commented on ZOOKEEPER-1169:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1708/#review1736
-----------------------------------------------------------
Ship it!
lgtm, I'll commit if the patch testing passes.
- Patrick
On 2011-09-02 18:56:43, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1708/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-02 18:56:43)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug zookeeper-1169.
bq. https://issues.apache.org/jira/browse/zookeeper-1169
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/main/org/apache/jute/compiler/JBuffer.java 466ea69
bq. src/java/main/org/apache/jute/compiler/JRecord.java bdae672
bq. src/java/main/org/apache/jute/compiler/generated/rcc.jj 511c17c
bq.
bq. Diff: https://reviews.apache.org/r/1708/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Fix compiler (eclipse) warnings in (generated) jute code
> --------------------------------------------------------
>
> Key: ZOOKEEPER-1169
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1169
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1169.patch
>
>
> Fixes for compiled jute parser:
> - missing generic types
> - added @SuppressWarnings("unused") because javacc adds a dead throws clause
> at the
> end of functions.
> Fixes for code compiled by jute compiler:
> - remove import java.util.* and use full ref to java.util.Arrays
> One warning fixed in non-compiled code:
> src/java/main/org/apache/jute/compiler/JRecord.java
> Rationale: The warnings in your IDE (eclipse) get useless if there are tons
> of them. This patch reduces many of them. Another issue with patch will
> reduce them to 8.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
