[
https://issues.apache.org/jira/browse/ZOOKEEPER-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096220#comment-13096220
]
Hadoop QA commented on ZOOKEEPER-1169:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492786/ZOOKEEPER-1169.patch
against trunk revision 1164632.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/489//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/489//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/489//console
This message is automatically generated.
> Fix compiler (eclipse) warnings in (generated) jute code
> --------------------------------------------------------
>
> Key: ZOOKEEPER-1169
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1169
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1169.patch
>
>
> Fixes for compiled jute parser:
> - missing generic types
> - added @SuppressWarnings("unused") because javacc adds a dead throws clause
> at the
> end of functions.
> Fixes for code compiled by jute compiler:
> - remove import java.util.* and use full ref to java.util.Arrays
> One warning fixed in non-compiled code:
> src/java/main/org/apache/jute/compiler/JRecord.java
> Rationale: The warnings in your IDE (eclipse) get useless if there are tons
> of them. This patch reduces many of them. Another issue with patch will
> reduce them to 8.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
