----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1715/#review1751 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/1715/#comment3981> it is unrelated to the rest of the patch, but I touched the file anyway and it's an obvious clean up that follows the boy scout rule.[1] The previous LOG initialization was very confusing. It made me think whether there's some JVM magic that would require LOG to be initialized in the static block rather then in the normal way. [1] http://pragmaticcraftsman.com/2011/03/the-boy-scout-rule/ - Thomas On 2011-09-05 15:55:47, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1715/ > ----------------------------------------------------------- > > (Updated 2011-09-05 15:55:47) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-731. > https://issues.apache.org/jira/browse/ZOOKEEPER-731 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ZooKeeper.java 00bac9f > > Diff: https://reviews.apache.org/r/1715/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
