----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1715/#review1753 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/ZooKeeper.java <https://reviews.apache.org/r/1715/#comment3983> I suspect LOG is initialized in the static to make initialization explicit - given logEnv uses LOG as an argument. We'll lose this with this change, i.e. someone might re-refactor the code and lose the implicit ordering. At the very least it would be a good idea to document. - Patrick On 2011-09-05 15:55:47, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1715/ > ----------------------------------------------------------- > > (Updated 2011-09-05 15:55:47) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-731. > https://issues.apache.org/jira/browse/ZOOKEEPER-731 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/ZooKeeper.java 00bac9f > > Diff: https://reviews.apache.org/r/1715/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
