[
https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100591#comment-13100591
]
Hadoop QA commented on ZOOKEEPER-1175:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12493641/ZOOKEEPER-1175.patch
against trunk revision 1165443.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/513//testReport/
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/513//console
This message is automatically generated.
> DataNode references parent node for no reason
> ---------------------------------------------
>
> Key: ZOOKEEPER-1175
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it
> needs to be. With the parent you need to get the parent before you can create
> the DataNode. Without the parent in the DataNode one can have a method
> tree.put(String path, new DataNode(...)).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
