[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100602#comment-13100602
 ] 

[email protected] commented on ZOOKEEPER-1175:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1758/
-----------------------------------------------------------

(Updated 2011-09-08 19:15:37.067342)


Review request for zookeeper.


Changes
-------

Didn't see one reference to DateNode.parent in UpgradeSnapShotV1.java.


Summary
-------



> DataNode references parent node for no reason
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-1175
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1175
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Minor
>         Attachments: ZOOKEEPER-1175.patch, ZOOKEEPER-1175.patch
>
>
> Having the parent referenced in a node makes the tree building harder then it 
> needs to be. With the parent you need to get the parent before you can create 
> the DataNode. Without the parent in the DataNode one can have a method 
> tree.put(String path, new DataNode(...)).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to