----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1772/#review1896 -----------------------------------------------------------
Looks good to me with just a couple questions: src/java/main/org/apache/zookeeper/server/DataTree.java <https://reviews.apache.org/r/1772/#comment4377> while you're here, add javadoc? src/java/main/org/apache/zookeeper/server/DataTree.java <https://reviews.apache.org/r/1772/#comment4378> javadoc? src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/1772/#comment4379> why is this dropped? (I didn't see it noted in the jira) - Patrick On 2011-09-14 10:12:15, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1772/ > ----------------------------------------------------------- > > (Updated 2011-09-14 10:12:15) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-1176. > https://issues.apache.org/jira/browse/ZOOKEEPER-1176 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/DataNode.java 9498204 > src/java/main/org/apache/zookeeper/server/DataTree.java 3987c54 > src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2946030 > > Diff: https://reviews.apache.org/r/1772/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
