> On 2011-09-14 18:34:18, Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/server/DataTree.java, line 160 > > <https://reviews.apache.org/r/1772/diff/3/?file=40496#file40496line160> > > > > while you're here, add javadoc?
I'm not ready yet with the DataTree. JavaDocs that I'd add now would get obsolete by the next patch. > On 2011-09-14 18:34:18, Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 265 > > <https://reviews.apache.org/r/1772/diff/3/?file=40498#file40498line265> > > > > why is this dropped? (I didn't see it noted in the jira) The setDataTreeInit method has been removed because it only did set the DataTree.initialized property which was never ever read again. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1772/#review1896 ----------------------------------------------------------- On 2011-09-15 08:31:34, Thomas Koch wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1772/ > ----------------------------------------------------------- > > (Updated 2011-09-15 08:31:34) > > > Review request for zookeeper. > > > Summary > ------- > > . > > > This addresses bug ZOOKEEPER-1176. > https://issues.apache.org/jira/browse/ZOOKEEPER-1176 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/DataNode.java d839a74 > src/java/main/org/apache/zookeeper/server/DataTree.java 27338d1 > src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2d9b104 > > Diff: https://reviews.apache.org/r/1772/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
