[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112790#comment-13112790
 ] 

Benjamin Reed commented on ZOOKEEPER-1201:
------------------------------------------

why is this classified as a blocker? it's really just defining constants for 
strings, changing an iterator, and extracting code blocks into methods right? i 
think the priority should be minor.

that said, the patch looks fine to me. eugene does this look okay to you?

> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
>                 Key: ZOOKEEPER-1201
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>            Priority: Blocker
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to