[
https://issues.apache.org/jira/browse/ZOOKEEPER-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112822#comment-13112822
]
[email protected] commented on ZOOKEEPER-1201:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2017/#review2026
-----------------------------------------------------------
Ship it!
Looks good; the code is much improved. However please note important change
regarding ZOOKEEPER-1195.
src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
<https://reviews.apache.org/r/2017/#comment4572>
Good point: "credentials" should be final.
src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
<https://reviews.apache.org/r/2017/#comment4573>
More concise, good.
src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
<https://reviews.apache.org/r/2017/#comment4574>
See https://issues.apache.org/jira/browse/ZOOKEEPER-1195 : this should be
kerberosName.getHostName(), not kerberosName.getServiceName().
- Eugene
On 2011-09-22 18:04:41, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2017/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-22 18:04:41)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-1201.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1201
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java
b3faa79
bq.
bq. Diff: https://reviews.apache.org/r/2017/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Clean SaslServerCallbackHandler.java
> ------------------------------------
>
> Key: ZOOKEEPER-1201
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1201
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1201.patch
>
>
> Severe code style issues.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
