[
https://issues.apache.org/jira/browse/ZOOKEEPER-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119638#comment-13119638
]
Hadoop QA commented on ZOOKEEPER-1212:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497538/ZOOKEEPER-1212.patch.txt
against trunk revision 1177432.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/601//console
This message is automatically generated.
> zkServer.sh stop action is not conformat with LSB para
> 20.2 Init Script Actions
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1212
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1212
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Roman Shaposhnik
> Attachments: ZOOKEEPER-1212.patch.txt
>
>
> According to LSB Core para 20.2:
> ==================================================================================
> Otherwise, the exit status shall be nonzero, as defined below.
> In addition to straightforward success, the following situations are
> also to be considered successful:
> •
> restarting a service (instead of reloading it) with the forcereload argument
> • running start on a service already running
> • running stop on a service already stopped or not running
> • running restart on a service already stopped or not running
> • running tryrestart on a service already stopped or not running
> ==================================================================================
> Yet, zkServer.sh fails on stop if it can't find a PID file:
> {noformat}
> stop)
> echo -n "Stopping zookeeper ... "
> if [ ! -f "$ZOOPIDFILE" ]
> then
> echo "error: could not find file $ZOOPIDFILE"
> exit 1
> else
> $KILL -9 $(cat "$ZOOPIDFILE")
> rm "$ZOOPIDFILE"
> echo STOPPED
> exit 0
> fi
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
