[jira] [Commented] (ZOOKEEPER-1212) zkServer.sh stop action is not conformat with LSB para 20.2 Init Script Actions

[Hudson (Commented) (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121833#comment-13121833
 ] 

Hudson commented on ZOOKEEPER-1212:
-----------------------------------

Integrated in ZooKeeper-trunk #1325 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/1325/])
    ZOOKEEPER-1212. zkServer.sh stop action is not conformat with LSB para 
20.2 Init Script Actions (Roman Shaposhnik via phunt)

phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1179336
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkServer.sh

                
> zkServer.sh stop action is not conformat with LSB para 
> 20.2 Init Script Actions
> -------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1212
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1212
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3, 3.4.0, 3.5.0
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>             Fix For: 3.3.4, 3.4.0, 3.5.0
>
>         Attachments: ZOOKEEPER-1212.patch.txt
>
>
> According to LSB Core para 20.2:
> ==================================================================================
> Otherwise,  the exit  status shall  be non­zero,  as de­fined below. 
> In addition to straightforward success, the following situations are
> also to be considered successful: 
> • 
> restarting a service (instead of reloading it) with the force­reload argument
> • running start on a service already running
> • running stop on a service already stopped or not running
> • running restart on a service already stopped or not running
> • running try­restart on a service already stopped or not running
> ==================================================================================
> Yet, zkServer.sh fails on stop if it can't find a PID file:
> {noformat}
> stop)
>     echo -n "Stopping zookeeper ... "
>     if [ ! -f "$ZOOPIDFILE" ]
>     then
>       echo "error: could not find file $ZOOPIDFILE"
>       exit 1
>     else
>       $KILL -9 $(cat "$ZOOPIDFILE")
>       rm "$ZOOPIDFILE"
>       echo STOPPED
>       exit 0
>     fi
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira