[
https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131447#comment-13131447
]
Hadoop QA commented on ZOOKEEPER-1216:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12499827/ZOOKEEPER-1216.patch
against trunk revision 1185994.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 94 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/634//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/634//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/634//console
This message is automatically generated.
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch,
> ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of
> Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my
> machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
