[
https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13134236#comment-13134236
]
[email protected] commented on ZOOKEEPER-1216:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2272/
-----------------------------------------------------------
(Updated 2011-10-24 16:59:05.682064)
Review request for zookeeper.
Summary
-------
ZOOKEEPER-1216 Fix more eclipse compiler warnings, also in Tests
I did set up a new work environment for a presentation of
Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my
machine.
Warnings are now down to 5! So no excuses to introduce new ones!
Fixed warnings:
removed unused imports
removed unused variables / methods
added missing generics
added ignore warnings for calls to deprecated code in tests
This addresses bug ZOOKEEPER-1216.
https://issues.apache.org/jira/browse/ZOOKEEPER-1216
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/JLineZNodeCompletor.java 02b0645
src/java/main/org/apache/zookeeper/Login.java 294801a
src/java/main/org/apache/zookeeper/ZooKeeperMain.java 98784d1
src/java/main/org/apache/zookeeper/server/ByteBufferOutputStream.java a2fcc95
src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1511ddb
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java d1ce278
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java e2e24aa
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 13541e8
src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 575a743
src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java ce239f9
src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java
b22e078
src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java
93c51b8
src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java 44f113a
src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6
src/java/test/org/apache/zookeeper/ZKTestCase.java b721cfc
src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java 738f665
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
7a5a75b
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
31d32f4
src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java a6a86d0
src/java/test/org/apache/zookeeper/test/ACLRootTest.java 7307cbf
src/java/test/org/apache/zookeeper/test/ClientTest.java e99d8df
src/java/test/org/apache/zookeeper/test/CreateModeTest.java a3b838a
src/java/test/org/apache/zookeeper/test/EventTypeTest.java e6a9826
src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 81ea12b
src/java/test/org/apache/zookeeper/test/FLETest.java b1b8e82
src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1b6ab70
src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java
5a9c759
src/java/test/org/apache/zookeeper/test/KeeperStateTest.java 55dc852
src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 21fed78
src/java/test/org/apache/zookeeper/test/LETest.java 78d68f0
src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java 2e0dcd9
src/java/test/org/apache/zookeeper/test/ObserverHierarchicalQuorumTest.java
9d373fc
src/java/test/org/apache/zookeeper/test/QuorumQuotaTest.java bef1a33
src/java/test/org/apache/zookeeper/test/QuorumTest.java c9c3b9a
src/java/test/org/apache/zookeeper/test/RepeatStartupTest.java 3421004
src/java/test/org/apache/zookeeper/test/SessionTest.java df9bd54
src/java/test/org/apache/zookeeper/test/WatcherTest.java fc3eccd
src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java fbf09b3
Diff: https://reviews.apache.org/r/2272/diff
Testing
-------
Thanks,
Thomas
> Fix more eclipse compiler warnings, also in Tests
> -------------------------------------------------
>
> Key: ZOOKEEPER-1216
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch,
> ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch
>
>
> I did set up a new work environment for a presentation of
> Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my
> machine.
> Warnings are now down to 5! So no excuses to introduce new ones!
> Fixed warnings:
> - removed unused imports
> - removed unused variables / methods
> - added missing generics
> - added ignore warnings for calls to deprecated code in tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
