[
https://issues.apache.org/jira/browse/BOOKKEEPER-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135806#comment-13135806
]
[email protected] commented on BOOKKEEPER-71:
---------------------------------------------------------
bq. On 2011-10-26 07:12:07, Sijie Guo wrote:
bq. > most is ok for me.
bq. >
bq. > there are two suggestions:
bq. >
bq. > 1) separate cppunit DEPS. since only test need cppunit, library doesn't.
bq. >
bq. > configure.ac
bq. >
bq. > -PKG_CHECK_MODULES([DEPS], [liblog4cxx protobuf cppunit])
bq. > +PKG_CHECK_MODULES([DEPS], [liglog4cxx protobuf])
bq. > +PKG_CHECK_MODULES([TESTDEPS], [cppunit])
bq. >
bq. > add TESTDEPS_LIBS only in test/Makefile.am .
bq. >
bq. > 2) cpp client can't build in gcc 3.4.0, since there is no tr1 library.
bq. >
bq. > I suggested that change the headers which using tr1 libary as below.
bq. >
bq. > +#ifdef HAVE_TR1
bq. > #include <tr1/memory>
bq. > +#else
bq. > +#include <boost/tr1/memory.hpp>
bq. > +#endif
bq. >
bq. > then checking tr1 library in configure.ac
bq. >
bq. > +AC_CHECK_HEADER(tr1/unordered_map, [AC_DEFINE([HAVE_TR1],[],["Have
tr1"])],[])
I'll fix these and upload a new patch. Thanks for the review :)
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2446/#review2848
-----------------------------------------------------------
On 2011-10-19 14:44:23, Ivan Kelly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2446/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-19 14:44:23)
bq.
bq.
bq. Review request for bookkeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The path to the protobuf spec is wrong in lib/Makefile.am.
bq.
bq. I also cleaned up the tests, and made it use the provided scripts to stop
and start bookkeeper and hedwig daemons.
bq.
bq.
bq. This addresses bug BOOKKEEPER-71.
bq. https://issues.apache.org/jira/browse/BOOKKEEPER-71
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. hedwig-server/src/test/java/org/apache/hedwig/ServerControlDaemon.java
14de705
bq. hedwig-client/src/main/cpp/test/util.h 2d92244
bq. hedwig-server/src/test/java/org/apache/hedwig/ServerControl.java be64f93
bq. hedwig-client/src/main/cpp/test/subscribetest.cpp 41da339
bq. hedwig-client/src/main/cpp/test/servercontrol.cpp 49696b7
bq. hedwig-client/src/main/cpp/test/servercontrol.h cac09e6
bq. hedwig-client/src/main/cpp/test/pubsubtest.cpp c0feade
bq. hedwig-client/src/main/cpp/test/main.cpp ef9190e
bq. hedwig-client/src/main/cpp/test/publishtest.cpp 95599d7
bq. hedwig-client/src/main/cpp/test/Makefile.am 84db87f
bq. hedwig-client/src/main/cpp/scripts/tester.sh c288076
bq. hedwig-client/src/main/cpp/scripts/network-delays.sh f566098
bq. hedwig-client/src/main/cpp/scripts/server-control.sh fa7f1c1
bq. hedwig-client/src/main/cpp/lib/Makefile.am 9a53138
bq. hedwig-client/src/main/cpp/README PRE-CREATION
bq. hedwig-client/src/main/cpp/config.h.in 19266b3
bq.
bq. Diff: https://reviews.apache.org/r/2446/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ivan
bq.
bq.
> hedwig c++ client does not build.
> ----------------------------------
>
> Key: BOOKKEEPER-71
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-71
> Project: Bookkeeper
> Issue Type: Bug
> Affects Versions: 3.4.0
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.0.0
>
> Attachments: BOOKKEEPER-71.diff
>
>
> The path to the protobuf spec is wrong in lib/Makefile.am.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
