[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136092#comment-13136092
 ] 

[email protected] commented on BOOKKEEPER-71:
---------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2446/
-----------------------------------------------------------

(Updated 2011-10-26 16:38:06.854585)


Review request for bookkeeper.


Changes
-------

Implemented the check for boost TR1 if builtin is not found.


Summary
-------

The path to the protobuf spec is wrong in lib/Makefile.am.

I also cleaned up the tests, and made it use the provided scripts to stop and 
start bookkeeper and hedwig daemons.


This addresses bug BOOKKEEPER-71.
    https://issues.apache.org/jira/browse/BOOKKEEPER-71


Diffs (updated)
-----

  hedwig-client/src/main/cpp/README PRE-CREATION 
  hedwig-client/src/main/cpp/config.h.in 19266b3 
  hedwig-client/src/main/cpp/lib/Makefile.am 9a53138 
  hedwig-client/src/main/cpp/scripts/network-delays.sh f566098 
  hedwig-client/src/main/cpp/scripts/server-control.sh fa7f1c1 
  hedwig-client/src/main/cpp/scripts/tester.sh c288076 
  hedwig-client/src/main/cpp/test/Makefile.am 84db87f 
  hedwig-client/src/main/cpp/test/main.cpp ef9190e 
  hedwig-client/src/main/cpp/test/publishtest.cpp 95599d7 
  hedwig-client/src/main/cpp/test/pubsubtest.cpp c0feade 
  hedwig-client/src/main/cpp/test/servercontrol.h cac09e6 
  hedwig-client/src/main/cpp/test/servercontrol.cpp 49696b7 
  hedwig-client/src/main/cpp/test/subscribetest.cpp 41da339 
  hedwig-client/src/main/cpp/test/util.h 2d92244 
  hedwig-server/src/test/java/org/apache/hedwig/ServerControl.java be64f93 
  hedwig-server/src/test/java/org/apache/hedwig/ServerControlDaemon.java 
14de705 

Diff: https://reviews.apache.org/r/2446/diff


Testing
-------


Thanks,

Ivan


                
> hedwig c++ client does not build. 
> ----------------------------------
>
>                 Key: BOOKKEEPER-71
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-71
>             Project: Bookkeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.0
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.0.0
>
>         Attachments: BOOKKEEPER-71.diff, BOOKKEEPER-71.diff
>
>
> The path to the protobuf spec is wrong in lib/Makefile.am. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to