[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138508#comment-13138508
 ] 

Patrick Hunt commented on ZOOKEEPER-1265:
-----------------------------------------

Don't the books say that all switch statements should have a default case? 
Perhaps we should refactor to print a warning in cases where we haven't handled 
a particular case? There will be some exceptions, but in general it seems like 
a good idea.

Something that PMD or checkstyle (findbugs?) can catch?
                
> Normalize switch cases lists on request types
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-1265
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1265
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-1265.patch
>
>
> As discussed on the list, it's probably an error that the 
> ReadOnlyRequestProcessor does not have multi alongside the other write 
> operations.
> Adding check to the lists may not make a difference by now since the ZK 
> client does not expose check as a first level request but only encapsulated 
> inside a multi request. However from a logical view, change belongs in these 
> lists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to