[
https://issues.apache.org/jira/browse/ZOOKEEPER-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138532#comment-13138532
]
Thomas Koch commented on ZOOKEEPER-1265:
----------------------------------------
There might be books saying so. Checkstyle can warn you on missing defaults and
fall throughs as currently used. My long term goal however is to get rid of
most of the switch statements altogether. Switch statements are often a sign of
missing object orientation. Logic that should be in a method of the object
switched over is external of the object in the switch cases.
I will update my devel branch on github soon and give some comments on it.
> Normalize switch cases lists on request types
> ---------------------------------------------
>
> Key: ZOOKEEPER-1265
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1265
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1265.patch
>
>
> As discussed on the list, it's probably an error that the
> ReadOnlyRequestProcessor does not have multi alongside the other write
> operations.
> Adding check to the lists may not make a difference by now since the ZK
> client does not expose check as a first level request but only encapsulated
> inside a multi request. However from a logical view, change belongs in these
> lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
