[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira reopened ZOOKEEPER-1270:
-----------------------------------------


Sorry for missing part of the fun.

Alex, Thanks for spotting the duplicate, that was a great catch. I'm not 
convinced that your patch completely solves the problem, though. LearnerHandler 
sends NEWLEADER concurrently with the leader adding NEWLEADER to 
outstandingRequests, so even fixing the barriers as you did does not prevent 
the race I mentioned above, I think.

I must say that I didn't find my proposed patch very elegant, but I'm not 
entirely sure that yours covers all cases, so let me know what you think.  
                
> testEarlyLeaderAbandonment failing intermittently, quorum formed, no serving.
> -----------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1270
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1270
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Flavio Junqueira
>            Priority: Blocker
>             Fix For: 3.4.0, 3.5.0
>
>         Attachments: ZOOKEEPER-1270-1194.patch, 
> ZOOKEEPER-1270-and-1194-branch34.patch, ZOOKEEPER-1270-and-1194.patch, 
> ZOOKEEPER-1270-and-1194.patch, ZOOKEEPER-1270.patch, ZOOKEEPER-1270.patch, 
> ZOOKEEPER-1270_br34.patch, ZOOKEEPER-1270tests.patch, 
> ZOOKEEPER-1270tests2.patch, testEarlyLeaderAbandonment.txt.gz, 
> testEarlyLeaderAbandonment2.txt.gz, testEarlyLeaderAbandonment3.txt.gz, 
> testEarlyLeaderAbandonment4.txt.gz, zookeeper-1270-1194-34.patch
>
>
> Looks pretty serious - quorum is formed but no clients can attach. Will 
> attach logs momentarily.
> This test was introduced in the following commit (all three jira commit at 
> once):
> ZOOKEEPER-335. zookeeper servers should commit the new leader txn to their 
> logs.
> ZOOKEEPER-1081. modify leader/follower code to correctly deal with new leader
> ZOOKEEPER-1082. modify leader election to correctly take into account current

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to