[ https://issues.apache.org/jira/browse/ZOOKEEPER-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147068#comment-13147068 ]
Hadoop QA commented on ZOOKEEPER-1292: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503081/ZOOKEEPER-1292.patch against trunk revision 1198053. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/783//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/783//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/783//console This message is automatically generated. > FLETest is flaky > ---------------- > > Key: ZOOKEEPER-1292 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1292 > Project: ZooKeeper > Issue Type: Improvement > Components: leaderElection > Reporter: Flavio Junqueira > Assignee: Flavio Junqueira > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1292.patch, ZOOKEEPER-1292.patch > > > testLE in FLETest is convoluted, difficult to read, and doesn't test FLE > appropriately. The goal of this jira is to clean it up and propose a more > reasonable test case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira