[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-1292:
----------------------------------------

    Attachment: ZOOKEEPER-1292.patch

I have added more comments and changed the timeouts:

* I have reduced the 2s timeout to 0.2s. I have made this timeout long because 
I wanted to make sure that if it hangs, then the chance of a false positive is 
low. Given that the test implemented here is supposed to be more reliable, it 
should never happen unless we run into a bug.
* I have reduced the 1s sleep to 0.1s. The idea of that sleep time is to 
represent the time a follower takes to declare the leader dead. Removing that 
sleep altogether means that a follower declares a leader dead right after 
having elected it. I have run several times without it, though, and it still 
works.
                
> FLETest is flaky
> ----------------
>
>                 Key: ZOOKEEPER-1292
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1292
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: leaderElection
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1292.patch, ZOOKEEPER-1292.patch, 
> ZOOKEEPER-1292.patch
>
>
> testLE in FLETest is convoluted, difficult to read, and doesn't test FLE 
> appropriately. The goal of this jira is to clean it up and propose a more 
> reasonable test case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to