[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191376#comment-13191376
]
Henry Robinson commented on ZOOKEEPER-1366:
-------------------------------------------
My feeling is that Ted's fixing a legitimate issue here, so we shouldn't hold
up the patch for a separate effort. Reworking how we deal with time is going to
be a big effort (Thread.sleep really does complicate things, plus there's the
question of how to actually inject a mock clock - as you say, such method calls
would need to be non-static but then we need to figure out how to get the right
implementation behind those methods). This patch doesn't get in the way of
doing a better job with time, and gives us the beginnings of a nice integration
point to mock clocks out.
So I'll file a separate JIRA to track being able to change our clock
implementation, and we can evaluate this on its own merits (might be nice to
run a soak test for a few hours here to make sure that there are no weird edge
cases that somehow got broken). Sound good?
> Zookeeper should be tolerant of clock adjustments
> -------------------------------------------------
>
> Key: ZOOKEEPER-1366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Ted Dunning
> Assignee: Ted Dunning
> Fix For: 3.4.3
>
> Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch
>
>
> If you want to wreak havoc on a ZK based system just do [date -s "+1hour"]
> and watch the mayhem as all sessions expire at once.
> This shouldn't happen. Zookeeper could easily know handle elapsed times as
> elapsed times rather than as differences between absolute times. The
> absolute times are subject to adjustment when the clock is set while a timer
> is not subject to this problem. In Java, System.currentTimeMillis() gives
> you absolute time while System.nanoTime() gives you time based on a timer
> from an arbitrary epoch.
> I have done this and have been running tests now for some tens of minutes
> with no failures. I will set up a test machine to redo the build again on
> Ubuntu and post a patch here for discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
