[
https://issues.apache.org/jira/browse/ZOOKEEPER-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191403#comment-13191403
]
Ted Dunning commented on ZOOKEEPER-1366:
----------------------------------------
@Mahadev,
I will produce patches for several versions as well as pre-built tar files.
This will include trunk, 3.4, 3.3.3 and 3.3.2.
The rate at which we encounter this kind of problem even at facilities that are
pretty sophisticated says to me that even if this isn't strictly a bug, then it
seriously decreases the probability that ZK will function well averaged over
all plausible users. Developers and users then think ZK is seriously buggy.
As such, we view this internally as a required fix that we will be deploying as
a patch on our current production version of ZK. Whether the ZK community
views it that way relative to 3.4 is an entirely separate question, of course.
@Pat, @Henry,
I really do think that doing the simple small thing (this patch) is important
without waiting on the resolution of the larger more comprehensive fix (fixing
time management in general). Thanks for your efforts in that vein.
@Camille,
I will have a slightly revised set of patches by tonight that fix the @Test
issue.
I also think that mocking was not at all the point of this patch. The only way
that this makes mocking easier is that we now have a (slightly) more
distinctive string to search for but as you point out, that isn't the real
issue anyway. Mocking static functions is becoming a more common capability,
but I would rather do it right when we do it.
> Zookeeper should be tolerant of clock adjustments
> -------------------------------------------------
>
> Key: ZOOKEEPER-1366
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1366
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Ted Dunning
> Assignee: Ted Dunning
> Fix For: 3.4.3
>
> Attachments: ZOOKEEPER-1366-3.3.3.patch, ZOOKEEPER-1366.patch,
> ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch, ZOOKEEPER-1366.patch
>
>
> If you want to wreak havoc on a ZK based system just do [date -s "+1hour"]
> and watch the mayhem as all sessions expire at once.
> This shouldn't happen. Zookeeper could easily know handle elapsed times as
> elapsed times rather than as differences between absolute times. The
> absolute times are subject to adjustment when the clock is set while a timer
> is not subject to this problem. In Java, System.currentTimeMillis() gives
> you absolute time while System.nanoTime() gives you time based on a timer
> from an arbitrary epoch.
> I have done this and have been running tests now for some tens of minutes
> with no failures. I will set up a test machine to redo the build again on
> Ubuntu and post a patch here for discussion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
