> On 2012-01-25 18:58:43, Eugene Koontz wrote:
> > conf/zoo_sample.cfg, line 30
> > <https://reviews.apache.org/r/3631/diff/2/?file=70794#file70794line30>
> >
> > note that 'org.apache.zookeeper' prefix breaks convention with other
> > variables.
zoo.cfg is read by the server. But here we need a setting on the client that
goes into the system properties namespace. So certainly it needs to be prefixed
in an appropriate way.
If we follow existing convention as seen here:
Boolean.getBoolean("zookeeper.disableAutoWatchReset");
As per comment below, the originally suggested key seems to be fine:
zookeeper.sasl.clientconfig
https://issues.apache.org/jira/browse/ZOOKEEPER-1373?focusedCommentId=13192817&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13192817
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3631/#review4595
-----------------------------------------------------------
On 2012-01-25 18:56:42, Eugene Koontz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3631/
> -----------------------------------------------------------
>
> (Updated 2012-01-25 18:56:42)
>
>
> Review request for zookeeper.
>
>
> Summary
> -------
>
> ZOOKEEPER-1373: Hardcoded SASL login context name clashes with Hadoop
> security configuration override
>
> Fix is to allow system property to designate the JAAS configuration section
> that the zookeeper client will use.
>
>
> This addresses bug ZOOKEEPER-1373.
> https://issues.apache.org/jira/browse/ZOOKEEPER-1373
>
>
> Diffs
> -----
>
> conf/zoo_sample.cfg aafb324
> src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40
> src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e
> src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedClientTest.java
> PRE-CREATION
>
> src/java/test/org/apache/zookeeper/test/SaslAuthFailDesignatedClientTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/3631/diff
>
>
> Testing
> -------
>
> "ant test" java tests pass.
>
>
> Thanks,
>
> Eugene
>
>
