> On 2012-01-26 18:18:55, Thomas wrote: > > conf/zoo_sample.cfg, line 30 > > <https://reviews.apache.org/r/3631/diff/3/?file=70817#file70817line30> > > > > What is the purpose of adding this to the server config? > >
Thomas, thanks for testing, and you are right - it doesn't belong here. It should probably be here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/Zookeeper+and+SASL I'll edit that today (feel free to do so also, and would be curious to hear your comments about this wiki entry, was it helpful for you?) - Eugene ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3631/#review4626 ----------------------------------------------------------- On 2012-01-26 00:30:39, Eugene Koontz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3631/ > ----------------------------------------------------------- > > (Updated 2012-01-26 00:30:39) > > > Review request for zookeeper. > > > Summary > ------- > > ZOOKEEPER-1373: Hardcoded SASL login context name clashes with Hadoop > security configuration override > > Fix is to allow system property to designate the JAAS configuration section > that the zookeeper client will use. > > > This addresses bug ZOOKEEPER-1373. > https://issues.apache.org/jira/browse/ZOOKEEPER-1373 > > > Diffs > ----- > > > src/java/test/org/apache/zookeeper/test/SaslAuthFailDesignatedClientTest.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/test/SaslAuthMissingClientConfigTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/SaslAuthDesignatedClientTest.java > PRE-CREATION > src/java/main/org/apache/zookeeper/Login.java 6d2a38c > src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e > conf/zoo_sample.cfg aafb324 > src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40 > > Diff: https://reviews.apache.org/r/3631/diff > > > Testing > ------- > > "ant test" java tests pass. > > > Thanks, > > Eugene > >
