[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235442#comment-13235442
 ] 

Rakesh R commented on ZOOKEEPER-1411:
-------------------------------------

Yeah, I understood setType() is throwing 'ConfigException' otherthan 
observer/participant and is sufficent to handle the comment#2.

But still I feel, the existing code base is not considering the 
'host:port:type' pattern. If you know, please point me to that code. I am 
thinking to avoid unwanted conditions.
The following snippet is from existing QPC and preparing the 'host:port:port' 
pattern, here its not separately handling the NFE of 
Integer.parseInt(parts[2]). This will be just propagating to the upper layer 
and throwing ConfigException.
{noformat}
} else if (parts.length == 3) {
     InetSocketAddress electionAddr = new InetSocketAddress(parts[0], 
Integer.parseInt(parts[2]));
     servers.put(Long.valueOf(sid), new QuorumServer(sid, addr, electionAddr));
{noformat}
                
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1411
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, 
> ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, 
> ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, 
> we will have all cluster membership definitions in a single file, and every 
> sever can have a copy of this file. 
> This also solves ZOOKEEPER-1113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to