[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235523#comment-13235523
 ] 

Rakesh R commented on ZOOKEEPER-1411:
-------------------------------------

@Flavio
Yeah, certainly no serious functional issues and I agree to throw exception 
back to the call chain. I just shared a thought, to remove the logic(also in 
the logs and java comments as shown below) of supporting 'host:port:type' 
pattern from the uploaded patch to make it fairer.
(FYI, Please see the Alex's comments regarding 'host:port:type')

{noformat}
QPC.java
private static final String wrongFormat = " does not have the form server_cofig 
or server_config;client_config"+
" where server_config is one of: host:port or host:port:port " +
" or host:port:port:type or host:port:type and client_config is port or 
host:port";
.
.
// length 3: host:port:port or host:port:type
.
.
{noformat}


                
> Consolidate membership management and add client port information
> -----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1411
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1411
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1411-ver1.patch, ZOOKEEPER-1411-ver2.patch, 
> ZOOKEEPER-1411-ver3.patch, ZOOKEEPER-1411-ver4.patch, 
> ZOOKEEPER-1411-ver5.patch
>
>
> Currently every server has a different configuration file. With this patch, 
> we will have all cluster membership definitions in a single file, and every 
> sever can have a copy of this file. 
> This also solves ZOOKEEPER-1113

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to