-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4737/
-----------------------------------------------------------
(Updated 2012-04-17 05:50:11.011776)
Review request for bookkeeper.
Changes
-------
attach a new patch addressed Ivan's comments.
Summary
-------
Currently we put all journal related operations in Bookie class. It would be
better to provide a journal manager to provide journal related operations. It
would make Bookie logic more clearly.
Besides that, some admin tools like BOOKKEEPER-183 needs to provide could use
JournalManager to read/check journal files directly.
This addresses bug BOOKKEEPER-218.
https://issues.apache.org/jira/browse/BOOKKEEPER-218
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
00cba69
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieBean.java
fa5171b
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieMXBean.java
8418469
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java
c172224
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java
e795fce
Diff: https://reviews.apache.org/r/4737/diff
Testing
-------
Thanks,
Sijie
