> On 2012-04-16 14:50:22, Ivan Kelly wrote: > > > > Sijie Guo wrote: > Thanks Ivan for reviewing. would like to update them in new patch. > > only one place about LastLogMark class I would like to explain. I would > like to provide a tool to read journal file in BOOKKEEPER-183, including > printing current LastLogMark. so admin guys could know the status of journal. > > so I leave LastLogMark as package accessible. does it make sense for you?
re: LastLogMark, thats fine. I simply didn't see why it needed to be accessible in the current code base, but if you have a plan for it there's no issue. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4737/#review6935 ----------------------------------------------------------- On 2012-04-17 05:50:11, Sijie Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4737/ > ----------------------------------------------------------- > > (Updated 2012-04-17 05:50:11) > > > Review request for bookkeeper. > > > Summary > ------- > > Currently we put all journal related operations in Bookie class. It would be > better to provide a journal manager to provide journal related operations. It > would make Bookie logic more clearly. > > Besides that, some admin tools like BOOKKEEPER-183 needs to provide could use > JournalManager to read/check journal files directly. > > > This addresses bug BOOKKEEPER-218. > https://issues.apache.org/jira/browse/BOOKKEEPER-218 > > > Diffs > ----- > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java > 00cba69 > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieBean.java > fa5171b > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieMXBean.java > 8418469 > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java > PRE-CREATION > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java > c172224 > > bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java > e795fce > > Diff: https://reviews.apache.org/r/4737/diff > > > Testing > ------- > > > Thanks, > > Sijie > >
