[
https://issues.apache.org/jira/browse/ZOOKEEPER-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544256#comment-13544256
]
Edward Ribeiro commented on ZOOKEEPER-1346:
-------------------------------------------
No problem, man. :)
Well, as for the 2nd Findbugs message, I'd suggest to modify the code at
Commands.MonitorCommand.run() as below:
[code]
if (stats.getServerState().equals("leader") && zkServer instanceof
LeaderZooKeeperServer) {
Leader leader = ((LeaderZooKeeperServer) zkServer).getLeader();
[/code]
It worked on my tests with Findbugs here. //Type checking can set up many traps.
Cheers,
Ed
> Handle 4lws and monitoring on separate port
> -------------------------------------------
>
> Key: ZOOKEEPER-1346
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1346
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Camille Fournier
> Assignee: Skye Wanderman-Milne
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1346.2.patch, ZOOKEEPER-1346.3.patch,
> ZOOKEEPER-1346.4.patch, ZOOKEEPER-1346.6.patch, ZOOKEEPER-1346_jetty.patch,
> ZOOKEEPER-1346.patch
>
>
> Move the 4lws to their own port, off of the client port, and support them
> properly via long-lived sessions instead of polling. Deprecate the 4lw
> support on the client port. Will enable us to enhance the functionality of
> the commands via extended command syntax, address security concerns and fix
> bugs involving the socket close being received before all of the data on the
> client end.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
