[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549144#comment-13549144
 ] 

Thawan Kooburat commented on ZOOKEEPER-1324:
--------------------------------------------

This is the first revision of the fix. Below are some thought about the diff

1. This change also prevent the leader from counting Observer's NEWLEADER_ACK 
causing the quorum to form prematurely. I will submit a unit test in a separate 
jira

2. I just noticed that the learner send ACK back to leader for both NEWLEADER 
and UPTODATE. I don't think UPTODATE's ack is part of the protocol, but didn't 
want to change it

3. After LearnerHandler call waitForNewLeaderAck(), it still wait and check if 
ZK server is started or not. I don't think we need that check anymore but it 
doesn't hurt to leave it as well. 
                
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1324
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Thawan Kooburat
>            Priority: Critical
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, 
> ZOOKEEPER-1324.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to