[
https://issues.apache.org/jira/browse/ZOOKEEPER-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556150#comment-13556150
]
Alexander Shraer commented on ZOOKEEPER-1324:
---------------------------------------------
Hi Flavio,
You're right, I should have paid closer attention. But I actually did notice
this JIRA and wrote Patrick about two weeks ago that I'm concerned about
several JIRAs touching the same code as ZK-107 and that we should commit ZK-107
ASAP. At some point I think we need a lock/freeze on significant other changes
to commit ZK-107, otherwise its an endless catch-up.
Regarding this specific patch. I'm not sure what it means to "port the patch".
The code in Leader.java and a few other files that is changed by ZK-1324 was
restructured and then modified in subtle ways ZK-107. I really believe that the
easiest and cleanest way to merge is to have ZK-107 as a starting point and
implement ZK-1324 relative to it (on top of it), and not the other way. It is
of course possible that Thawan or you do that on your local machine (you can
use the latest ZK-107 patch) but then the re-implementation of ZK-1324 will be
part of ZK-107. I think this is not a good solution, since ZK-1324 will be
spread across two JIRAs and it will be difficult to find problems later In both
these JIRAs.
Alex
> Remove Duplicate NEWLEADER packets from the Leader to the Follower.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-1324
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1324
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Reporter: Mahadev konar
> Assignee: Thawan Kooburat
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch,
> ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch, ZOOKEEPER-1324.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
