[
https://issues.apache.org/jira/browse/ZOOKEEPER-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559424#comment-13559424
]
Hadoop QA commented on ZOOKEEPER-1625:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12565908/ZOOKEEPER-1625.patch
against trunk revision 1434978.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1352//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1352//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1352//console
This message is automatically generated.
> zkServer.sh is looking for clientPort in config file, but it may no longer be
> there with ZK-1411
> ------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1625
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1625
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1625.patch
>
>
> zkServer.sh is currently looking for "clientPort" entry in the static
> configuration file and uses it to contact the server.
> With ZOOKEEPER-1411 clientPort is part of the dynamic configuration, and may
> appear in the separate dynamic configuration file. The "clientPort" entry may
> no longer be in the static config file.
> With the proposed patch zkServer.sh first looks in the old (static) config
> file, then if clientPort is not there, it figures out the id of the server by
> looking at myid file, and then using that id finds the client port in the
> dynamic config file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
