[
https://issues.apache.org/jira/browse/ZOOKEEPER-1625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560970#comment-13560970
]
Patrick Hunt commented on ZOOKEEPER-1625:
-----------------------------------------
Previously we relied on the server code itself to check that the client port
parameter was set, however now we're additionally checking in the zkServer
script. Seems like an unnecessary check.
also is the following necessary/useful?
bq. + echo "Client port not found in static config file. Looking in
dynamic config file."
> zkServer.sh is looking for clientPort in config file, but it may no longer be
> there with ZK-1411
> ------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1625
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1625
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1625.patch
>
>
> zkServer.sh is currently looking for "clientPort" entry in the static
> configuration file and uses it to contact the server.
> With ZOOKEEPER-1411 clientPort is part of the dynamic configuration, and may
> appear in the separate dynamic configuration file. The "clientPort" entry may
> no longer be in the static config file.
> With the proposed patch zkServer.sh first looks in the old (static) config
> file, then if clientPort is not there, it figures out the id of the server by
> looking at myid file, and then using that id finds the client port in the
> dynamic config file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
