[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13694141#comment-13694141
 ] 

Marshall McMullen commented on ZOOKEEPER-1719:
----------------------------------------------

No tests were provided because this is only an init script...
                
> zkCli.sh, zkServer.sh and zkEnv.sh regression caused by ZOOKEEPER-1663
> ----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1719
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1719
>             Project: ZooKeeper
>          Issue Type: Bug
>         Environment: Linux (Ubuntu 12.04) with dash shell
>            Reporter: Marshall McMullen
>            Assignee: Marshall McMullen
>         Attachments: ZOOKEEPER-1719.patch
>
>
> This fix from ZOOKEEPER-1663 is incorrect. It assumes the shell is bash since 
> it uses bash array construction, e.g.:
> {code}
>  96   LIBPATH=("${ZOOKEEPER_PREFIX}"/share/zookeeper/*.jar)
> {code}
> This does NOT work if /bin/sh points to /bin/dash as it does on Ubuntu. 
> It fails as so:
> {quote}
> zkEnv.sh: 96: zkEnv.sh: Syntax error: "(" unexpected (expecting "fi")         
>                                                                               
>                                                                               
>                          
> {quote}
> If I change the shebang at the top to use "/bin/bash" instead of "/bin/sh" it 
> works as expected. I don't know the full details of why using a bash array 
> was chosen as the solution but I don't think it is the right way to deal with 
> spaces in these paths...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to