[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696091#comment-13696091
 ] 

Hudson commented on ZOOKEEPER-1719:
-----------------------------------

Integrated in ZooKeeper-trunk #1975 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/1975/])
    ZOOKEEPER-1719. zkCli.sh, zkServer.sh and zkEnv.sh regression caused by 
ZOOKEEPER-1663
  (Marshall McMullen via camille) (Revision 1497830)

     Result = FAILURE
camille : 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1497830
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkCleanup.sh
* /zookeeper/trunk/bin/zkCli.sh
* /zookeeper/trunk/bin/zkEnv.sh

                
> zkCli.sh, zkServer.sh and zkEnv.sh regression caused by ZOOKEEPER-1663
> ----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1719
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1719
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0, 3.4.5
>         Environment: Linux (Ubuntu 12.04) with dash shell
>            Reporter: Marshall McMullen
>            Assignee: Marshall McMullen
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1719.patch
>
>
> This fix from ZOOKEEPER-1663 is incorrect. It assumes the shell is bash since 
> it uses bash array construction, e.g.:
> {code}
>  96   LIBPATH=("${ZOOKEEPER_PREFIX}"/share/zookeeper/*.jar)
> {code}
> This does NOT work if /bin/sh points to /bin/dash as it does on Ubuntu. 
> It fails as so:
> {quote}
> zkEnv.sh: 96: zkEnv.sh: Syntax error: "(" unexpected (expecting "fi")         
>                                                                               
>                                                                               
>                          
> {quote}
> If I change the shebang at the top to use "/bin/bash" instead of "/bin/sh" it 
> works as expected. I don't know the full details of why using a bash array 
> was chosen as the solution but I don't think it is the right way to deal with 
> spaces in these paths...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to