[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752300#comment-13752300
 ] 

Germán Blanco commented on ZOOKEEPER-1713:
------------------------------------------

It seems that the nanosecs value affected by this problem is always 0 in my 
machine, so there is actually no difference. But I guess that for those 
machines that provide a value there will be.
This means I haven't been able to check that there was a problem and it was 
removed, although it seems obvious in the code. I did test that zkfuse worked 
ok after (and in my case also before) the patch was applied.
                
> wrong time calculation in zkfuse.cc
> -----------------------------------
>
>                 Key: ZOOKEEPER-1713
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1713
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5
>         Environment: Linux
>            Reporter: Germán Blanco
>            Assignee: Germán Blanco
>            Priority: Trivial
>             Fix For: 3.5.0, 3.4.6
>
>         Attachments: ZOOKEEPER-1713.patch
>
>
> A colleague of mine has spotted this error in time calculation in the code in 
> zkfuse.cc lines 81 to 85:
> inline
> uint64_t nanosecsToMillisecs(uint64_t nanosecs)
> {
>     return nanosecs * 1000000;
> }
> I am not sure how this method is used, but for sure it will make something 
> wrong happen if it is.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to