[
https://issues.apache.org/jira/browse/ZOOKEEPER-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752319#comment-13752319
]
Hadoop QA commented on ZOOKEEPER-1713:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12600374/ZOOKEEPER-1713.patch
against trunk revision 1516126.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1546//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1546//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1546//console
This message is automatically generated.
> wrong time calculation in zkfuse.cc
> -----------------------------------
>
> Key: ZOOKEEPER-1713
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1713
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.5
> Environment: Linux
> Reporter: Germán Blanco
> Assignee: Germán Blanco
> Priority: Trivial
> Fix For: 3.5.0, 3.4.6
>
> Attachments: ZOOKEEPER-1713.patch
>
>
> A colleague of mine has spotted this error in time calculation in the code in
> zkfuse.cc lines 81 to 85:
> inline
> uint64_t nanosecsToMillisecs(uint64_t nanosecs)
> {
> return nanosecs * 1000000;
> }
> I am not sure how this method is used, but for sure it will make something
> wrong happen if it is.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
