[
https://issues.apache.org/jira/browse/ZOOKEEPER-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783501#comment-13783501
]
Patrick Hunt commented on ZOOKEEPER-1766:
-----------------------------------------
[~jackie.chang] if you are ready for review on this patch please hit "submit
patch" button at the top of the jira web ui for this issue. That way the
workflow will proceed. Thanks!
> Consistent log severity level guards and statements
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1766
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1766
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Jackie Chang
> Priority: Minor
> Attachments: ZOOKEEPER-1766.patch
>
>
> A log statement should be guarded by its matching severity level. A log
> statement like
> if (LOG.isTraceEnabled()) {
> LOG.info("Session closing: 0x" + Long.toHexString(sessionId));
> doesn't make much sense because the log message is only printed out when
> TRACE-level is enabled. This inconsistency was possibly introduced when
> developers demoted the original log statement from INFO but forgot to change
> its corresponding log severity level.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
