[
https://issues.apache.org/jira/browse/ZOOKEEPER-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784829#comment-13784829
]
Hadoop QA commented on ZOOKEEPER-1766:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12605186/ZOOKEEPER-1766.patch
against trunk revision 1528586.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1633//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1633//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1633//console
This message is automatically generated.
> Consistent log severity level guards and statements
> ---------------------------------------------------
>
> Key: ZOOKEEPER-1766
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1766
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.4.5
> Reporter: Jackie Chang
> Priority: Minor
> Attachments: ZOOKEEPER-1766.patch
>
>
> A log statement should be guarded by its matching severity level. A log
> statement like
> if (LOG.isTraceEnabled()) {
> LOG.info("Session closing: 0x" + Long.toHexString(sessionId));
> doesn't make much sense because the log message is only printed out when
> TRACE-level is enabled. This inconsistency was possibly introduced when
> developers demoted the original log statement from INFO but forgot to change
> its corresponding log severity level.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
