[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808214#comment-13808214
 ] 

Sijie Guo commented on BOOKKEEPER-698:
--------------------------------------

hmm. sounds like I missed this when merging BOOKKEEPER-602. thanks for catching 
this.

two comments

- move shutdown outside writeLock.
- why you use "+" in log message? it seems unnecessary.


> Bookie client closure is not considering timeoutExecutor
> --------------------------------------------------------
>
>                 Key: BOOKKEEPER-698
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-698
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-client
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-698.patch
>
>
> 'timeoutExecutor' is leaking for every bookie client, it should be closed 
> during bookie client closure. I've seen in tests, scheduler is running and 
> periodically executing the TimeoutTask even after bk client closure.
> Also, timeoutExecutor is missing thread name. IMHO, no need to raise another 
> issue, just including the small change with this JIRA.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to